Skip to content

fix: UI/UX review — polish and accessibility (PR 2 of 2)#38

Merged
ianchesal merged 6 commits intomainfrom
ian/ui-ux-review-pr2
Apr 18, 2026
Merged

fix: UI/UX review — polish and accessibility (PR 2 of 2)#38
ianchesal merged 6 commits intomainfrom
ian/ui-ux-review-pr2

Conversation

@ianchesal
Copy link
Copy Markdown
Collaborator

@ianchesal ianchesal commented Apr 18, 2026 •
edited
Loading

Summary

Addresses the Low priority findings from the UI/UX expert review. Stacked on PR #37.

  • Fix 6: Watch ↗ link restyled from dark stone to amber outline — consistent with warm palette
  • Fix 8: Browse Criterion/IMDB links removed from sidebar; added to Add Movie page where contextually useful
  • Fix 9: Mobile bottom nav active tab uses filled amber-600 pill + bold label — unmissable at a glance
  • Fix 10: Decorative emoji icons wrapped in aria-hidden spans in sidebar, mobile nav, and AskClaudeLink

Test plan

  • 175 tests passing (up from 168 at PR 1 merge point)
  • New test files: tests/sidebar.test.tsx, tests/add-page.test.tsx
  • Verify watchlist: Watch link is amber-toned, not dark stone
  • Verify sidebar: Browse Criterion/IMDB gone; Add Movie page has them instead
  • Verify mobile: active tab has solid amber-600 icon pill + bold label text
  • Verify with screen reader: nav emoji icons skipped, text labels announced correctly

🤖 Generated with Claude Code

ianchesal and others added 5 commits April 18, 2026 18:36
@ianchesal @claude
fix: restyle Watch link to amber outline to match palette
227c60a 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ianchesal @claude
fix: move Browse Criterion/IMDB links from sidebar to Add page
1c39dcb 
Trims the sidebar utility footer by removing the Browse Criterion and Browse IMDB links, relocating them as helper links directly on the Add Movie page where they are contextually useful.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ianchesal @claude
fix: strengthen mobile bottom nav active tab indicator
c8cf0ed 
Replace bg-amber-100 pill with bg-amber-600 for higher-contrast active
state, and add font-bold to the active tab label. Update tests accordingly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ianchesal @claude
fix: add aria-hidden to decorative emoji icons in nav components
f7a66b0 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ianchesal @claude
fix: add aria-hidden to decorative emoji icons in sidebar utility but…
d2cd7c0 
…tons

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Base automatically changed from ian/ui-ux-review to main April 18, 2026 21:15
@ianchesal ianchesal merged commit 5b19d56 into main Apr 18, 2026
1 check passed
@ianchesal ianchesal deleted the ian/ui-ux-review-pr2 branch April 18, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ianchesal